Date: Wed, 18 May 2011 23:41:17 +0100 From: Matthew Seaman <m.seaman@infracaninophile.co.uk> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-ports@FreeBSD.org Subject: Re: Optional Patches Message-ID: <4DD44B0D.5000402@infracaninophile.co.uk> In-Reply-To: <4DD44596.9050401@FreeBSD.org> References: <C9301CD1-D2C0-449A-BD85-8488FDC028B5@conundrum.com> <4DD443DD.90909@infracaninophile.co.uk> <4DD44596.9050401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig08C2E1D110048182F34559F2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 18/05/2011 23:17, Doug Barton wrote:
> On 05/18/2011 15:10, Matthew Seaman wrote:
>> # Testing both WITH_ and WITHOUT_ is a good idea...
>=20
> I'm not sure why you would need to test both, unless it's to catch wack=
y
> stuff coming in from the environment?
That's one reason. Another is that it makes the layout of the .if block
handling that option independent of whether the option defaults to on or
off, which might just help avoid some logic errors.
Neither of which reasons is sufficiently compelling to make that style
preferable to just testing only one of WITH_ or WITHOUT_ in general.
> The usual way is to test the opposite of the default. So for default on=
> you would test that WITHOUT_FOO is not defined.
There are plenty of examples of both styles in the ports. Personal
preferences of the port maintainer is probably the biggest deciding facto=
r.
Cheers,
Matthew
--=20
Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard
Flat 3
PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate
JID: matthew@infracaninophile.co.uk Kent, CT11 9PW
--------------enig08C2E1D110048182F34559F2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.16 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk3USxQACgkQ8Mjk52CukIzTmgCeMhU27egIks5ypS+Ldu98WUp/
ro0An08IE+SaHDy/WUMXpML4cBCQKU/p
=7Zbp
-----END PGP SIGNATURE-----
--------------enig08C2E1D110048182F34559F2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DD44B0D.5000402>