Date: Sat, 4 May 2013 09:02:23 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r317243 - head/deskutils/menumaker Message-ID: <20130504070223.GV12114@ithaqua.etoilebsd.net> In-Reply-To: <20130504050636.GA54091@FreeBSD.org> References: <201305032040.r43KeNIb027043@svn.freebsd.org> <20130504050636.GA54091@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--y5yQnZmVlpWlTeDv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 04, 2013 at 05:06:36AM +0000, Alexey Dokuchaev wrote: > On Fri, May 03, 2013 at 08:40:23PM +0000, Baptiste Daroussin wrote: > > New Revision: 317243 > > URL: http://svnweb.freebsd.org/changeset/ports/317243 > >=20 > > Log: > > Fix build with bmake > >=20 > > @@ -14,6 +10,7 @@ MAINTAINER=3D ports@FreeBSD.org > > COMMENT=3D Menu generator for X Window Managers and desktop environmen= ts > > =20 > > USE_PYTHON=3D yes > > +USE_GMAKE=3D yes >=20 > Since you decided not to surround it with bmake-specific conditional this > time, I think it would be nice to add a comment instead, e.g.: >=20 > USE_GMAKE=3Dyes # fails with bmake(1) >=20 > I usually try to check periodically why some ports need gmake(1); it would > make it easier for me with such comments, thanks! I'll keep surrounding with test on .PARSEDIR then regards, Bapt --y5yQnZmVlpWlTeDv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGEsn8ACgkQ8kTtMUmk6ExYFgCdEA6KwS4zc7LqPHtbOWZ+ISPc T6kAnj68euKTkRAbAelTluyRmpRukkm2 =/Prc -----END PGP SIGNATURE----- --y5yQnZmVlpWlTeDv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130504070223.GV12114>