Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Jun 2017 13:24:06 +0000 (UTC)
From:      "John W. De Boskey" <jwd@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r320406 - head/libexec/rshd
Message-ID:  <201706271324.v5RDO63A014743@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jwd
Date: Tue Jun 27 13:24:06 2017
New Revision: 320406
URL: https://svnweb.freebsd.org/changeset/base/320406

Log:
  A little tweak for performance
  
  Reviewed by: adrian
  Approved by: rmacklem (mentor)
  MFC after: 3 weeks

Modified:
  head/libexec/rshd/rshd.c

Modified: head/libexec/rshd/rshd.c
==============================================================================
--- head/libexec/rshd/rshd.c	Tue Jun 27 12:56:36 2017	(r320405)
+++ head/libexec/rshd/rshd.c	Tue Jun 27 13:24:06 2017	(r320406)
@@ -191,7 +191,7 @@ doit(struct sockaddr *fromp)
 	struct passwd *pwd;
 	u_short port;
 	fd_set ready, readfrom;
-	int cc, fd, nfd, pv[2], pid, s;
+	int cc, nfd, pv[2], pid, s;
 	int one = 1;
 	const char *cp, *errorstr;
 	char sig, buf[BUFSIZ];
@@ -496,8 +496,7 @@ doit(struct sockaddr *fromp)
 #ifdef USE_BLACKLIST
 	blacklist(0, STDIN_FILENO, "success");
 #endif
-	for (fd = getdtablesize(); fd > 2; fd--)
-		(void) close(fd);
+	closefrom(3);
 	if (setsid() == -1)
 		syslog(LOG_ERR, "setsid() failed: %m");
 	if (setlogin(pwd->pw_name) < 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201706271324.v5RDO63A014743>