Date: Sun, 29 Aug 2004 23:47:32 +0200 From: Ulrich Spoerlein <q@uni.de> To: mezz7@cox.net Cc: pav@FreeBSD.org Subject: Re: ports/71111: [PATCH] games/wesnoth: update to 0.8.3 Message-ID: <20040829214732.GA75289@galgenberg.net> In-Reply-To: <20040829200158.ZBNC17927.lakermmtao01.cox.net@smtp.east.cox.net> References: <20040829200158.ZBNC17927.lakermmtao01.cox.net@smtp.east.cox.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 29.08.2004 at 16:01:59 -0400, mezz7@cox.net wrote: > I will have to agree with pav here about looks very ugly. I don't > approve this patch, but I shall take some good parts from this patch > after ports tree freeze in my new patch. Sorry, it will not make it > before ports tree freeze. However, the reason I don't approve this > patch is remove pkg-plist, force gcc 3.3 and etc. USE_GCC is only needed for -STABLE because it doesn't compile with gcc 2.95 and I am unable to fix this C++ crap... It probably looks ugly, because it creates the PLIST, installs all files and then adds all the directories to the PLIST. Half of it could be avoided, if a plain 'make install' wouldn't overflow the argument list. Anyway, I talked to the wesnoth people and they'll probably fix this by using some secret incantation of find(1) to install these files (wargus' Makefiles are a mess...) I'd rather go for an automated pkg-plist creation, because there will always be new scenarios and campaigns added to wesnoth, which will add considerably churn to the CVS. The pkg-plist is 1849 lines right now.... Ulrich Spoerlein -- PGP Key ID: F0DB9F44 Get it while it's hot! PGP Fingerprint: F1CE D062 0CA9 ADE3 349B 2FE8 980A C6B5 F0DB 9F44 "They that can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety." -- Benjamin Franklin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040829214732.GA75289>