Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Mar 2006 19:04:57 +0000 (GMT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/sys socketvar.h
Message-ID:  <20060315190416.V36621@fledge.watson.org>
In-Reply-To: <20060315185909.GA16188@garage.freebsd.pl>
References:  <200603151230.k2FCU6sH042768@repoman.freebsd.org> <20060315185909.GA16188@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help

On Wed, 15 Mar 2006, Pawel Jakub Dawidek wrote:

> +>   Add SS_PROTOREF socket flag, which represents a strong reference by the
> +>   protocol to the socket.  Normally protocol references are weak: that is,
> +>   the socket layer can tear down the socket (and hence protocol state)
> +>   when it finds convenient.  This flag will allow the protocol to
> +>   explicitly declare to the socket layer that it is maintaining a
> +>   strong reference, rather than the current implicit model associated
> +>   with so_pcb pointer values and repeated attempts to possibly free the
> +>   socket.
> [...]
> +> @@ -208,6 +208,7 @@ extern struct mtx accept_mtx;
> +>  #define	SS_ASYNC		0x0200	/* async i/o notify */
> +>  #define	SS_ISCONFIRMING		0x0400	/* deciding to accept connection req */
> +>  #define	SS_ISDISCONNECTED	0x2000	/* socket disconnected from peer */
> +> +#define	SS_PROTOREF		0x400	/* strong protocol reference */
>
> You probably wanted 0x4000 here, no 0x400 which is already defined as 
> SS_ISCONFIRMING.

Indeed.  I decided to hand type the change instead of cutting down the current 
sockref patch to one chunk, and obviously that was a bad idea.

Thanks!

Robert N M Watson



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060315190416.V36621>