Date: Tue, 11 Oct 2005 16:45:52 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Andrew Thompson <thompsa@freebsd.org>, Brooks Davis <brooks@one-eyed-alien.net>, Yar Tikhiy <yar@comp.chem.msu.su>, Pawel Jakub Dawidek <pjd@freebsd.org>, FreeBSD Current <current@freebsd.org> Subject: Re: panic: ifc_free_unit: bit is already cleared Message-ID: <20051011234551.GF13461@odin.ac.hmc.edu> In-Reply-To: <20051011234014.GA6179@heff.fud.org.nz> References: <20051005024903.GA72743@heff.fud.org.nz> <20051005203639.GA20552@garage.freebsd.pl> <20051005205515.GA30350@odin.ac.hmc.edu> <20051005210950.GB75848@heff.fud.org.nz> <20051009232849.GA27349@comp.chem.msu.su> <20051010022208.GA97249@heff.fud.org.nz> <20051010202900.GA24213@odin.ac.hmc.edu> <20051011210602.GA5714@heff.fud.org.nz> <20051011220749.GD13461@odin.ac.hmc.edu> <20051011234014.GA6179@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
--924gEkU1VlJlwnwX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 12, 2005 at 12:40:14PM +1300, Andrew Thompson wrote: > On Tue, Oct 11, 2005 at 03:07:49PM -0700, Brooks Davis wrote: > > On Wed, Oct 12, 2005 at 10:06:02AM +1300, Andrew Thompson wrote: > > > On Mon, Oct 10, 2005 at 01:29:00PM -0700, Brooks Davis wrote: > > > > On Mon, Oct 10, 2005 at 03:22:08PM +1300, Andrew Thompson wrote: > > > > > I have been testing this patch and I think it fixes all the probl= ems > > > > > discussed. > > > > >=20 > > > >=20 > > > > I don't see any reason why you can't just replace the specific dest= roy > > > > calls with calls to ifc_simple_destroy(). That would avoid expandi= ng > > > > the API. > > >=20 > > > I have updated the patch and yes, its a nicer way to do it. Please > > > review. > > >=20 > > > Ive run through interations of create/kldunload with bridge, disc, > > > faith, gif, gre and ppp with extra printf's and its freeing correctly. > >=20 > > This looks good to me, thanks for working on this and doing the > > <ifn>_destory removals. Let's see about getting this committed. > >=20 >=20 > There was one problem where pflog0 would loop on EINVAL since it was a > precloned device, livelocking the system. >=20 > This addition fixes it, it was either this or a dying flag. Good catch. I think this is an OK fix. Did lo0 have the same issue? -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --924gEkU1VlJlwnwX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFDTE6vXY6L6fI4GtQRAoEXAJ9BKGk0Df82RCFXz5ClJ0ZfX4JSQQCdGNlh BYQ4c+1D3sRfJcbqkhuU46Q= =nbws -----END PGP SIGNATURE----- --924gEkU1VlJlwnwX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051011234551.GF13461>