Date: Wed, 21 Jun 2006 14:52:53 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Florent Thoumie <flz@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr src/share/man/man8 rc.subr.8 Message-ID: <20060621105253.GE45947@comp.chem.msu.su> In-Reply-To: <1150883785.3467.4.camel@mayday.esat.net> References: <200606210942.k5L9gtAi060504@repoman.freebsd.org> <1150883785.3467.4.camel@mayday.esat.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 21, 2006 at 10:56:25AM +0100, Florent Thoumie wrote: > On Wed, 2006-06-21 at 09:42 +0000, Yar Tikhiy wrote: > > yar 2006-06-21 09:42:55 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc rc.subr > > share/man/man8 rc.subr.8 > > Log: > > Quite a number of rc.d scripts try to load kernel modules. Many > > of them do that conditionally depending on kldstat. The code is > > duplicated all over, but bugs can be uniqie. > > > > To make the things more consistent, introduce a new rc.subr function, > > load_kld, which takes care of loading a kernel module conditionally. > > > > (Found this lying for a while in my p4 branch for various hacks.) > > I added such a function some weeks ago (far more simple though). Talking > with pjd, I've backed it out to use the somewhat straight-forward method > he used in rc.d/geli. rc.d/geli doesn't use kldload directlty, so it certainly won't benefit from the function I introduced. > I don't have a particular feeling against your function but it uses > commands that may not be available early enough (getopt, egrep). While > it's easy to remove the getopt dependency (see rc.d/mdconfig), it's not > the case for egrep. It's POSIX getopts, which ought to be a shell built-it by its design. egrep is used with -e only, one can avoid using it if egrep isn't available yet. The only issue is true and false, I was sure they were in /bin, but it can be fixed easily. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060621105253.GE45947>