Date: Mon, 4 Dec 2006 23:40:07 -0800 (PST) From: mjacob@freebsd.org To: Attilio Rao <attilio@freebsd.org>, Ade Lovett <ade@freebsd.org>, Bruce Evans <bde@zeta.org.au> Cc: freebsd-scsi@freebsd.org Subject: Re: a code reduction function addition to cam_xpt Message-ID: <20061204233902.K21080@ns1.feral.com> In-Reply-To: <3bbf2fe10612041532r24989510g90e41eb6f41cadb5@mail.gmail.com> References: <20061119161631.L44297@ns1.feral.com> <3bbf2fe10611191631h6883b862uf8088533913a7bc6@mail.gmail.com> <20061120221153.GA5155@lor.one-eyed-alien.net> <3bbf2fe10611201418m15d50703m37d9d5620e5c832d@mail.gmail.com> <20061204150922.F18492@ns1.feral.com> <3bbf2fe10612041532r24989510g90e41eb6f41cadb5@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> 2006/12/5, mjacob@freebsd.org <mjacob@freebsd.org>: >> >> >> Was there ever a consensus about this to the point of: >> >> a) Yes, this is a nice thing to have >> b) Should it be a define or a function? >> >> I obviously think yes for #a. I lean toward a function. Comments? > > a) yes > b) define > A number of folks have spoken. On balance, the function is more readable. Thanks all.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061204233902.K21080>