Date: Fri, 28 Feb 2014 20:21:46 +0100 From: olli hauer <ohauer@gmx.de> To: Martin Wilke <miwi@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r346541 - head/www/mod_log_sql2 Message-ID: <5310E1CA.1000504@gmx.de> In-Reply-To: <201402281619.s1SGJBFL065513@svn.freebsd.org> References: <201402281619.s1SGJBFL065513@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-02-28 17:19, Martin Wilke wrote: > Author: miwi > Date: Fri Feb 28 16:19:10 2014 > New Revision: 346541 > URL: http://svnweb.freebsd.org/changeset/ports/346541 > QAT: https://qat.redports.org/buildarchive/r346541/ > > Log: > - Stage support > > Modified: > head/www/mod_log_sql2/Makefile > > Modified: head/www/mod_log_sql2/Makefile > ============================================================================== > --- head/www/mod_log_sql2/Makefile Fri Feb 28 16:18:59 2014 (r346540) > +++ head/www/mod_log_sql2/Makefile Fri Feb 28 16:19:10 2014 (r346541) > @@ -25,7 +25,6 @@ USE_MYSQL= yes > USE_APACHE= 22 > CONFIGURE_ENV+= LIBS="-L${LOCALBASE}/lib -L${LOCALBASE}/lib/mysql" > > -NO_STAGE= yes > .include <bsd.port.pre.mk> > > .if defined(WITH_DBI) || exists(${LOCALBASE}/include/dbi/dbi.h) > @@ -39,6 +38,6 @@ SSL_PLIST= "@comment " > .endif > > post-install: > - @${APXS} -e -a -n "${SHORTMODNAME}" "${APACHEMODDIR}/${MODULENAME}.so" > + @${APXS} -e -a -n "${SHORTMODNAME}" "${STAGEDIR}${APACHEMODDIR}/${MODULENAME}.so" > > .include <bsd.port.post.mk> > Hi Martin, this will not work as expected, that's why this port is was not converted. The makefile from mod_log_sql will try to install all three modules into ${PREFIX}/${APACHEMODDIR} and not into ${STAGEDIR}${PREFIX}/${APACHEMODDIR}. The changed APXS line does not install mod_log_sql, it will enable the module in httpd.conf (param -e -a) (even during make stage) In case someone will run 'make stage' with sudo or as root the httpd.conf will messed up with a non installed module. The only way to enable staging for this port is to patch the Makefile.in by changing the apcs instructions from - 'apxs -n $(SHORTMODNAME) -i $(MODULENAME).la' to + 'apxs -S LIBEXECDIR=${STAGEDIR}${PREFIX}/${APACHEMODDIR} -n $(SHORTMODNAME) -i $(MODULENAME).la' for mod_log_sql_mysql, mod_log_sql_logio and mod_log_sql_ssl -- Regards, olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5310E1CA.1000504>