Date: Sat, 4 May 2013 10:24:28 -0400 From: Eitan Adler <eadler@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r317320 - in head: Mk audio/gmidimonitor audio/lv2core audio/patchage audio/raul audio/slv2 databases/dbf editors/libreoffice games/tuxmath games/tuxtype graphics/mapnik java/openjdk6 j... Message-ID: <CAF6rxgkgNiknhc83RfhOJ%2Bu=afkwdxG7rkUYDq%2Ba6kNE4-nU_Q@mail.gmail.com> In-Reply-To: <5185181E.9040104@FreeBSD.org> References: <201305041406.r44E69Bw096955@svn.freebsd.org> <CAF6rxgm7P=TcmjBU6cupitON3ORTBBO0jUt%2B1wDL0ASzOJ%2BQPg@mail.gmail.com> <5185181E.9040104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 May 2013 10:15, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 5/4/2013 9:12 AM, Eitan Adler wrote: >> On 4 May 2013 10:06, Bryan Drewery <bdrewery@freebsd.org> wrote: >>> Author: bdrewery >>> Date: Sat May 4 14:06:08 2013 >>> New Revision: 317320 >>> URL: http://svnweb.freebsd.org/changeset/ports/317320 >>> >>> Log: >>> - When DISABLE_MAKE_JOBS or MAKE_JOBS_UNSAFE is set, also set >>> MAKE_JOBS_NUMBER to 1. This makes it safe to do -j${MAKE_JOBS_NUMBER} >>> without any extra logic. >> >> No. It does not make this safe unless -B is also specified to make. >> >> It is possible that a Makefile will work with "make" but be buggy when >> "make -j1" is used. >> > > How is -j1 not safe? I test built these and they were fine. Its been a *long* time since I looked but I seem to remember that -j: - changes which features are available (disables 'compatibility mode') - changes the order in which certain dependencies are evaluated I am not saying that these ports will break, but that it is not a direct consequence: it needs to be tested each time. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkgNiknhc83RfhOJ%2Bu=afkwdxG7rkUYDq%2Ba6kNE4-nU_Q>