Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Feb 2008 06:54:30 GMT
From:      Kip Macy <kmacy@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 134824 for review
Message-ID:  <200802050654.m156sUWj003953@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=134824

Change 134824 by kmacy@kmacy:storage:toehead on 2008/02/05 06:53:46

	don't proceed with tx if the intorface isn't up or the driver isn't running

Affected files ...

.. //depot/projects/toehead/sys/dev/cxgb/cxgb_multiq.c#2 edit

Differences ...

==== //depot/projects/toehead/sys/dev/cxgb/cxgb_multiq.c#2 (text+ko) ====

@@ -422,13 +422,16 @@
 	txq = &qs->txq[TXQ_ETH];
 	
 	mtx_assert(&txq->lock, MA_OWNED);
-	KASSERT(qs->idx == 0, ("invalid qs %d", qs->idx));
 	
  retry:	
 	if (!pi->link_config.link_ok)
 		initerr = ENXIO;
 	else if (qs->qs_flags & QS_EXITING)
 		initerr = ENXIO;
+	else if ((pi->ifp->if_drv_flags & IFF_DRV_RUNNING) == 0)
+		initerr = ENXIO;
+	else if ((pi->ifp->if_flags & IFF_UP) == 0)
+		initerr = ENXIO;
 	else if (immpkt) {
 
 		if (!buf_ring_empty(&txq->txq_mr)) 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802050654.m156sUWj003953>