Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Dec 2020 21:02:19 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Glen Barber <gjb@freebsd.org>
Cc:        Kyle Evans <kevans@freebsd.org>, "Rodney W. Grimes" <rgrimes@freebsd.org>,  src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 70e64ba44941 - main - release.sh: Update GITROOT URL
Message-ID:  <CANCZdfoE5KuWPHNmqK1=W0TW6LE8sxwBV51SndoDYwE3zXyFOw@mail.gmail.com>
In-Reply-To: <20201230022128.GE1206@FreeBSD.org>
References:  <202012291441.0BTEf1X9009764@gitrepo.freebsd.org> <202012300018.0BU0I7gn079533@gndrsh.dnsmgr.net> <CACNAnaF0pMGzZRsHueR_o-xwD_CjX6yyHqO-SNGTPy3tsinLAg@mail.gmail.com> <20201230022128.GE1206@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 29, 2020, 7:21 PM Glen Barber <gjb@freebsd.org> wrote:

> On Tue, Dec 29, 2020 at 06:36:45PM -0600, Kyle Evans wrote:
> > On Tue, Dec 29, 2020, 18:18 Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net>
> > wrote:
> >
> > > > The branch main has been updated by gjb:
> > > >
> > > > URL:
> > >
> https://cgit.FreeBSD.org/src/commit/?id=70e64ba4494190e64ab8faa04d744182d420c275
> > > >
> > > > commit 70e64ba4494190e64ab8faa04d744182d420c275
> > > > Author:     Glen Barber <gjb@FreeBSD.org>
> > > > AuthorDate: 2020-12-29 14:34:05 +0000
> > > > Commit:     Glen Barber <gjb@FreeBSD.org>
> > > > CommitDate: 2020-12-29 14:40:28 +0000
> > > >
> > > >     release.sh: Update GITROOT URL
> > > >
> > > >     Hard-code the GITROOT for the ports tree to use cgit-beta
> > > >     until the ports repository is converted.
> > > >
> > > >     While here, remove $FreeBSD$ RCS IDs.
> > >
> > > So how do I know what version of some file I am looking at
> > > once it has been dis-associated from a git clone?
> > >
> > > Is there some new mechanism that can give me the cadence of
> > > say, /etc/pkg/FreeBSD.conf once its FreBSD ID is riped out?
> > >
> > > Also if $FreeBSD$ needs to be removed, can we please just do
> > > it in one massive tree wide commit rather than have this
> > > random piece wise needless noise in 1000's of commits?
> >
> >
> >
> > I don't see any particularly compelling reason to strip these tags,
> > personally. I stripped them from caroot because we embedded them in
> > generated files and it creates a lot of noise on updatecerts that I do
> not
> > need/want, while providing no value to justify the noise for a purely
> > generated file.
>
> They are not used/updated, so why keep a tag that does not expand to any
> useful information?
>

Deleting all the $FreeBSD$ in on go is massively unwise (or as the British
might say, "a very brave plan"). It will screw up MFCs on an epic scale for
years for no real benefit to pay for that extra developer time. It itself
can't be MFCd. It's a terrible idea. We should not be deleting them, except
judiciously for things that cannot be MFCd. With the subversion exporter,
they will live on in stable/12.

Warner

>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoE5KuWPHNmqK1=W0TW6LE8sxwBV51SndoDYwE3zXyFOw>