Date: Sat, 4 Mar 2017 12:25:05 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: rgrimes@freebsd.org Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5 lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5 libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc Message-ID: <7ed86250-8f8e-d034-0959-dc46e8973583@FreeBSD.org> In-Reply-To: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net> References: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--aP9IGkHpjpKPdIdnIDEIfNAS70tTiibMq
Content-Type: multipart/mixed; boundary="v2XVT711d3DdXRCAMPThmOPsQXhNHbhgp";
protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: rgrimes@freebsd.org
Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org,
svn-src-all@freebsd.org, svn-src-head@freebsd.org
Message-ID: <7ed86250-8f8e-d034-0959-dc46e8973583@FreeBSD.org>
Subject: Re: svn commit: r314657 - in head/kerberos5: . lib/libgssapi_krb5
lib/libgssapi_ntlm lib/libgssapi_spnego lib/libhdb lib/libkafs5 lib/libkrb5
libexec/hprop libexec/kpasswdd tools/asn1_compile tools/slc
References: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201703042020.v24KKD5N078654@pdx.rh.CN85.dnsmgr.net>
--v2XVT711d3DdXRCAMPThmOPsQXhNHbhgp
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 3/4/2017 12:20 PM, Rodney W. Grimes wrote:
> -- Start of PGP signed section.
> [ Charset windows-1252 unsupported, converting... ]
>> On 3/4/2017 7:34 AM, Rodney W. Grimes wrote:
>>> What is ${.CURDIR:H:H} ????? Yes that seems to work but now we are o=
bscuring
>>> ../.. into makefile syntax magic, probably not a grand idea.
>> It just trims off the last directory component. This both reduces
>> namecache lookups, lessens the amount of data in a log, and makes
>> debugging a log simpler by not having a crazy path like:
>> /home/bdrewery/big/git/buildserver/sys/modules/usb/template/../../../d=
ev/usb/template/usb_template.c
>>
>> It's far simpler to understand and work with:
>> /home/bdrewery/big/git/buildserver/sys/dev/usb/template/usb_template.c=
>>
>> The only downside is it is slightly more obscure in a Makefile, but on=
ce
>> you know what :H is then it's not a problem. This is why SRCTOP is ev=
en
>> better than this as it is far more clear than even :H and avoids the
>> ../../ problems.
> Lets do one or the other, but not both ${SRCTOP} and :H:H:H. It appear=
s
> that we now have a mix and mashed up some one way others the other.
That I can agree with. I would prefer to standardize on SRCTOP as :H is
too obscure without learning about make details.
--=20
Regards,
Bryan Drewery
--v2XVT711d3DdXRCAMPThmOPsQXhNHbhgp--
--aP9IGkHpjpKPdIdnIDEIfNAS70tTiibMq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJYuyKhAAoJEDXXcbtuRpfPUa8IAJC8qre6gw81FKEUoAe7oRgO
YV7tOYDWANTQ6eF5UCqec8buRG5PECWyQ1udlXoE+8RWW5/qlYLDSERRm7tSOlrk
AATKgyzUTgqzMQOsJuObjYnmwhMxcPpoGfKJft037nI/rGX6g9M8B8AuS+4yc4Vg
19cz743wJvOSUUnph5XOLFJRm8ugsc49CpePdz9EwdHeAlS6M0aYHzPp+lyGChxx
5YWzc9QRtdwMIWKz/tN7h869przGo1t1R+JlSQPt30G4Kkuyr+HpFuOaX0rHDW6e
WV8/EzWGi6a1ZdLgpATe8vFhtdR/uzyv/WppkEOhnCSz0hRWPq87BZxhYdn9lG8=
=Z4WD
-----END PGP SIGNATURE-----
--aP9IGkHpjpKPdIdnIDEIfNAS70tTiibMq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7ed86250-8f8e-d034-0959-dc46e8973583>