Date: Mon, 30 Sep 2002 20:35:48 +0200 (CEST) From: Ernst de Haan <znerd@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: mharo@FreeBSD.org Subject: ports/43537: portlint 2.3.3 does not handle URLs that end in '.html' Message-ID: <200209301835.g8UIZmUC000890@localhost.jollem.com>
next in thread | raw e-mail | index | archive | help
>Number: 43537
>Category: ports
>Synopsis: portlint 2.3.3 does not handle URLs that end in '.html'
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Sep 30 11:40:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Ernst de Haan
>Release: FreeBSD 4.6-STABLE i386
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD heinz 4.6-STABLE FreeBSD 4.6-STABLE #2: Wed Aug 28 23:38:45 CEST 2002 root@heinz:/usr/obj/usr/src/sys/HEINZ i386
>Description:
When I run portlint on ports/java/jdk12, I get
>How-To-Repeat:
# cd /usr/ports/java/jdk12
# portlint
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-comment.
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/pkg-descr.
OK: checking Makefile.
WARN: Makefile 85: whitespace before end of line.
WARN: possible direct use of command "awk" found. use ${AWK} instead.
WARN: possible direct use of command "install" found. use ${INSTALL_foobaa} instead.
WARN: possible use of absolute pathname "/usr/bin/cpio", in Makefile.
FATAL: URL "http://www.sun.com/software/java2/download.html" should end with "/".
WARN: extra item placed in the *_DEPENDS section.
WARN: "PKGNAMESUFFIX" has to appear earlier in Makefile.
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/distinfo.
OK: checking /usr/home/ernst/freebsd/ports/java/jdk12/files/patch-aa.
1 fatal errors and 6 warnings found.
The 'FATAL' line is incorrect IMO.
>Fix:
Suggestion:
See if the filename ends with .html or .htm and allow that too. But then
perhaps you should extend this to allow any URL if it ends with:
/[^/]+\.[^/]+$
So that's a / followed by a number of non-slash characters, followed by a dot,
followed by another number of non-slash characters.
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209301835.g8UIZmUC000890>