Date: Tue, 12 Aug 2008 17:41:34 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Ed Schouten <ed@80386.nl> Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>, Bruce Evans <brde@optusnet.com.au> Subject: Re: cvs commit: src/sys/dev/io iodev.c Message-ID: <20080812144134.GC1803@deviant.kiev.zoral.com.ua> In-Reply-To: <20080812141521.GX99951@hoeg.nl> References: <200808081343.m78DhwYE068477@repoman.freebsd.org> <200808081226.32089.jhb@freebsd.org> <20080809130929.P77335@delplex.bde.org> <200808091555.25020.jhb@freebsd.org> <20080812014937.E21092@besplex.bde.org> <20080812231130.D760@besplex.bde.org> <20080812141521.GX99951@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--VywGB/WGlW4DM4P8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 12, 2008 at 04:15:21PM +0200, Ed Schouten wrote: > Hello all, >=20 > * Bruce Evans <brde@optusnet.com.au> wrote: > > I checked that bpf panics (even under UP) due to the obvious bugs in > > its d_close(): > > > > # Generate lots of network activity using something like: > > sysctl net.inet.icmp.icmplim=3D0; ping -fq localhost & > > > > # Race to panic eventually: > > while :; do tcpdump -i lo0 & sleep 0.001; revoke /dev/bpf0 > > > > Most or all device drivers have obvious bugs in their d_close(); bpf > > is just a bit easier to understand and more likely to cause a panic > > than most device drivers, since it is simple and frees resources. A > > panic is very likely when si_drv1 is freed, and si_drv1 is only locked > > accidentally. >=20 > I remember I once warned people about this on the lists. It seems the > cdevpriv API is protected against this, so the following patch turns BPF > into a single device node, which can handle revoke() calls properly. >=20 > I wrote this patch a month ago, but eventually I didn't commit this. I > think I should, though. >=20 > http://80386.nl/files/bpf-cdevpriv.diff Did you tested cdevpriv'ed bpf against revoke ?=20 --VywGB/WGlW4DM4P8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkihoR4ACgkQC3+MBN1Mb4hUkgCgvcyvZcaq22HKyvj145/tD5KU P4QAoIDjgU0ONMB7gZPnDIXGLOWZJfVc =Ci6V -----END PGP SIGNATURE----- --VywGB/WGlW4DM4P8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080812144134.GC1803>