Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 12 Jan 2019 03:30:49 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 234816] [NEW PORT] sysutils/ioc: CLI tool for jail management with libioc{age,ell}
Message-ID:  <bug-234816-21822-Ltn0wgTVlK@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-234816-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-234816-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234816

Kubilay Kocak <koobs@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koobs@FreeBSD.org
             Status|New                         |Open
           Keywords|                            |needs-patch

--- Comment #4 from Kubilay Kocak <koobs@FreeBSD.org> ---
Some review items:

- Python ports should almost always be prefixed with
PKGNAMEPREFIX=3DPYTHON_PKGNAMEPREFIX. This is particularly the case with po=
rts
(python packages) that support multiple Python versions, which is almost ev=
ery
python software in existence.

- If pip isn't a *_DEPENDS, remove the commented line, or comment above the
commented line as to why it's commented (not yet ported, future reference,
whatever)

- Add python as a secondary (virtual) CATEGORIES

- NO_BUILD=3Dyes - replace with USE_PYTHON=3Ddistutils autoplist (variable =
is
currently defined but empty incorrectly). Python packages that support these
mechanisms should use them in their ports, as it ensures a standard and
consistent build / installation, without manual porting. This also obviates=
 the
need to use the custom do-install targets/entries, which are not currently
installing things into the correct places (PREFIX/lib, not in the python
site-packages dir)

- Use USE_RC_SUBR for the rc.d script, after copying the file from WRKSRC to
files/ (FILESDIR) at post-extract: time. See:
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#rc-scripts

- The PORTNAME is not consistent with the setup.py:name (ioc_cli). Since the
latter should/will be registered in PyPI (sdist distribution not withstandi=
ng),
the PORTNAME should match what will eventually be its canonical name.

More broadly, there is a naming conflict/confusion created between this and=
 the
dependent port (in bug 234812) born purely from the lack of a prefix (see
above).

I would standardize/canonicalize the upstream naming, and re-submit
patches/port names as follows (feel free to change the canonical names
themselves):

- sysutils/py-libioc (setup.py:name=3Dlibioc)
- sysutils/py-ioc (setup.py:name=3Dioc)

Alternatively:

- sysutils/py-libioc (setup.py:name=3Dlibioc)
- sysutils/py-ioc-cli (setup.py:name=3Dioc-cli)

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-234816-21822-Ltn0wgTVlK>