Date: Wed, 28 Feb 2007 13:02:16 +1030 From: "Daniel O'Connor" <doconnor@gsoft.com.au> To: cvs-all@freebsd.org Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@freebsd.org> Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <200702281302.18223.doconnor@gsoft.com.au> In-Reply-To: <200702272233.l1RMXocb004983@repoman.freebsd.org> References: <200702272233.l1RMXocb004983@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart9773721.Ip9sBIVfIQ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 28 February 2007 09:03, Warner Losh wrote: > Create a new quirk READ_CAPACITY_OFFBY1 and add a quirk for the > SanDISK ImageMate that I have that suffers from this problem (the > SDDR-31). It intercepts the READ_CAPACITY response and adjusts it > from number of sectors to max sector for devices with this quirk. > > Reading the Linux source suggests that there are a host of > other devices with this issue, including iPods and some popular > cameras. I've not added quirks for them, since I don't have the > devices in front of me to test. Couldn't you automatically test for this? ie try and read the last sector. Obviously if there is a real error in the last sector you'd get a bogus res= ult=20 but I don't think that is likely to be very common :) =2D-=20 Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C --nextPart9773721.Ip9sBIVfIQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQBF5Omy5ZPcIHs/zowRAiUOAJ9R1wim3Q+3/EafipTfu/oZKAPMegCgoTfE Ttwmp/BkdH33Tnzk70rwoEE= =kvdu -----END PGP SIGNATURE----- --nextPart9773721.Ip9sBIVfIQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702281302.18223.doconnor>