Date: Sun, 2 Aug 2015 23:19:15 -0600 (MDT) From: Gerald Pfeifer <gerald@pfeifer.com> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r383894 - in head/ports-mgmt/portlint: . src Message-ID: <alpine.LSU.2.20.1508022310110.10946@tuna.site> In-Reply-To: <201504130453.t3D4rQmX037343@svn.freebsd.org> References: <201504130453.t3D4rQmX037343@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 13 Apr 2015, Joe Marcus Clarke wrote:
> Update to 2.16.3.
>
> * Check the patches to make sure they were generated using ``make
> patch'' [1]
Why this? Looking both at this as well as the actual code...
> while (<IN>) {
> $whole .= $_;
> + if (/^--- /) {
> + if ($_ !~ /UTC\s*$/) {
> + &perror("WARN", $file, -1, "patch was not generated using ".
> + "``make makepatch''. It is recommended to use ".
> + "``make makepatch'' to ensure proper patch format.");
> + }
> + }
...I cannot help feeling that this is a little over the edge. What
is wrong about emulators/wine-devel/files/patch-partial-reservation
and especially emulators/wine-devel/files/patch-dlls_kernel32_Makefile.in
or lang/gcc6-devel/patch-unwind-ia64.h ?
It appears the source of this is a somewhat underspecified request
in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197747
The problem are not actually "patches that don't have UTC in "---" line"
as stated there. It's patches that feature a date and time there to being
with _and_ in a different format.
Mind relaxing this a bit again?
Thanks,
Gerald
PS: I just found https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197747
as well.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.20.1508022310110.10946>