Date: Mon, 28 Jul 2014 14:18:25 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r269127 - head/sys/dev/usb/wlan Message-ID: <CAJ-VmokdRh9UzTPCO=bZECjXH8HzAEngPYNGfkiX_ekK1pdXtQ@mail.gmail.com> In-Reply-To: <53D6BB0B.4010604@selasky.org> References: <201407261606.s6QG61le092895@svn.freebsd.org> <CAJ-Vmo=gy99iyOwoeCBKKMTAba1CycJgQBO2ti2=eFR_9ht-UQ@mail.gmail.com> <53D3FDEC.5040000@selasky.org> <CAJ-VmonefZWYRdF2mbhKQ-GVhUn-32nop1TsXKq=ZT3xP5mmsA@mail.gmail.com> <53D55CD9.4000408@selasky.org> <CAJ-VmonV=mt5_6xZa-naD%2BS3mPKE14wTUnTyFJrBnE3aA8MRMw@mail.gmail.com> <53D6B784.6080102@selasky.org> <CAJ-Vmo=rgrXab5XUg93uQPYkpq362P4WALU3SCZR2XYiUvLjYA@mail.gmail.com> <53D6BB0B.4010604@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 July 2014 14:05, Hans Petter Selasky <hps@selasky.org> wrote: > On 07/28/14 22:52, Adrian Chadd wrote: >> >> The whole rate control thing from net80211 has to be upgraded. Drivers >> shouldn't be using ni->ni_txrate for anything other than informational >> purposes, yet .. well, that's not the case. > > > Hi, > > Should the rate be extracted from the NET80211 header instead, and if yes, > how? It's a little more complicated than that. The problem is that in an SMP world, ni_txrate can change at any point due to decisions made in other threads. So for control lookups, it can't just be some thing in the struct, it has to be something serialised behind locks. Ideally the ratectl API stuff will be extended to return a list of rates to use and _that_ function can do the sanity checking and locking and such. It's just unfortunate that the ni_txrate stuff was used in a lot of wifi drivers. :( -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokdRh9UzTPCO=bZECjXH8HzAEngPYNGfkiX_ekK1pdXtQ>