Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Nov 2015 15:58:53 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Dag-Erling Sm??rgrav <des@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r400658 - in head/net: . p5-ldap2pf p5-ldap2pw p5-srv2pf
Message-ID:  <20151102155853.GA29265@FreeBSD.org>
In-Reply-To: <201511021504.tA2F4qg3052690@repo.freebsd.org>
References:  <201511021504.tA2F4qg3052690@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 02, 2015 at 03:04:52PM +0000, Dag-Erling Sm??rgrav wrote:
> New Revision: 400658
> URL: https://svnweb.freebsd.org/changeset/ports/400658
> 
> Log:
>   Three small Perl utilities

It's normally expected to briefly mention in the commit log what are those
programs are about.

> Added:
>   head/net/p5-ldap2pf/
> [...]
> +PORTNAME=	ldap2pw
> +PORTVERSION=	20151101
> +CATEGORIES=	net
> +MASTER_SITES=	GH

This last line is not needed because USE_GITHUB implies it.

> Added: head/net/p5-srv2pf/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/net/p5-srv2pf/pkg-descr	Mon Nov  2 15:04:52 2015	(r400658)
> @@ -0,0 +1,4 @@
> +The srv2pf utility creates and updates PF tables based on SRV, A or
> +AAAA records.

Missin Oxford comma in "A or" which we typically respect in FreeBSD.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151102155853.GA29265>