Date: Sat, 19 Oct 2013 23:37:21 +0200 From: Juergen Lock <nox@jelal.kn-bremen.de> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Juergen Lock <nox@FreeBSD.org>, svn-ports-all@FreeBSD.org, Juergen Lock <nox@jelal.kn-bremen.de>, ports-committers@FreeBSD.org Subject: Re: svn commit: r330781 - in head/www/vdr-plugin-live: . files Message-ID: <20131019213721.GA34367@enceladus10.kn-bremen.de> In-Reply-To: <20131019213405.GA32859@FreeBSD.org> References: <201310182230.r9IMUHGJ058516@svn.freebsd.org> <20131019133626.GA15196@FreeBSD.org> <20131019205731.GA26972@enceladus10.kn-bremen.de> <20131019213405.GA32859@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 19, 2013 at 09:34:05PM +0000, Alexey Dokuchaev wrote: > On Sat, Oct 19, 2013 at 10:57:31PM +0200, Juergen Lock wrote: > > On Sat, Oct 19, 2013 at 01:36:26PM +0000, Alexey Dokuchaev wrote: > > > On Fri, Oct 18, 2013 at 10:30:17PM +0000, Juergen Lock wrote: > > > > New Revision: 330781 > > > > URL: http://svnweb.freebsd.org/changeset/ports/330781 > > > > [...] > > > > +pre-install: > > > > + ${MKDIR} ${PREFIX}/lib/vdr > > > > + > > > > > > Hmm, since it's unstaged port, it looks like pre-install should really be > > > pre-su-install, otherwise it will fail unless built/installed by root, if > > > I'm not mistaken. > > > > Hm I guess you're right, even tho it probably won't matter much in > > practice as the mkdir is only needed when PREFIX is != LOCALBASE > > and vdr itself is installed in LOCALBASE and created the dir there, > > which means this cannot really run anyway. > > I see. Provided that your analysis is correct, I guess there is no need > for immediate action, since this issue would become void anyways once > the port would be stagified. > > ./danfe I fixed it nevertheless, be it only not to serve as a bad example. :) Thanx, Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131019213721.GA34367>