Date: Thu, 07 Nov 2019 23:24:57 +0300 From: Max Brazhnikov <makc@freebsd.org> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r516987 - in head: net/remotebox net/remotebox/files x11/gcb x11/gcb/files Message-ID: <5176694.8gLySxXtyI@mercury.ph.man.ac.uk> In-Reply-To: <201911071707.xA7H7Pj0023431@repo.freebsd.org> References: <201911071707.xA7H7Pj0023431@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 7 Nov 2019 17:07:25 +0000 (UTC) Mateusz Piotrowski wrote: > Author: 0mp > Date: Thu Nov 7 17:07:24 2019 > New Revision: 516987 > URL: https://svnweb.freebsd.org/changeset/ports/516987 > > Log: > Remove suffix from Icon key in desktop entries > > Suffixes, like .png, are not part of the specification. Although many > ports like misc/xfce4-appfinder have implemented workarounds for it, > ports like x11/rofi are missing icons due to a suffix being present in the > Icon key. > > References: > - https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html > - https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup > > Approved by: portmgr (blanket, runtime fixes) > > Modified: > head/net/remotebox/Makefile > head/net/remotebox/files/remotebox.desktop > head/x11/gcb/Makefile > head/x11/gcb/files/gcb.desktop > > Modified: head/net/remotebox/Makefile > ============================================================================== > --- head/net/remotebox/Makefile Thu Nov 7 17:00:49 2019 (r516986) > +++ head/net/remotebox/Makefile Thu Nov 7 17:07:24 2019 (r516987) > @@ -3,7 +3,7 @@ > > PORTNAME= remotebox > DISTVERSION= 2.5 > -PORTREVISION= 1 > +PORTREVISION= 2 > CATEGORIES= net > MASTER_SITES= http://remotebox.knobgoblin.org.uk/downloads/ > DISTNAME= RemoteBox-${DISTVERSION} > > Modified: head/net/remotebox/files/remotebox.desktop > ============================================================================== > --- head/net/remotebox/files/remotebox.desktop Thu Nov 7 17:00:49 2019 (r516986) > +++ head/net/remotebox/files/remotebox.desktop Thu Nov 7 17:07:24 2019 (r516987) > @@ -5,6 +5,6 @@ Type=Application > Name=Remotebox > GenericName=Remotebox > Comment=Open Source VirtualBox Client with Remote Management > -Icon=remotebox.png > +Icon=remotebox > Exec=remotebox > Categories=System > > Modified: head/x11/gcb/Makefile > ============================================================================== > --- head/x11/gcb/Makefile Thu Nov 7 17:00:49 2019 (r516986) > +++ head/x11/gcb/Makefile Thu Nov 7 17:07:24 2019 (r516987) > @@ -3,7 +3,7 @@ > > PORTNAME= gcb > PORTVERSION= 0.2.8 > -PORTREVISION= 8 > +PORTREVISION= 9 > CATEGORIES= x11 > MASTER_SITES= http://freebsd.flatrate.ru/distfiles/ \ > http://ccbsd9.csie.nctu.edu.tw/~cp76/gcb/ > > Modified: head/x11/gcb/files/gcb.desktop > ============================================================================== > --- head/x11/gcb/files/gcb.desktop Thu Nov 7 17:00:49 2019 (r516986) > +++ head/x11/gcb/files/gcb.desktop Thu Nov 7 17:07:24 2019 (r516987) > @@ -2,7 +2,7 @@ > Encoding=UTF-8 > Name=Gtk Copy-paste Buffer > Comment=A GTK+ tool for managing x11 cut-buffers > -Icon=gcb.png > +Icon=gcb > Exec=gcb -B > Type=Application > Categories=GNOME;Application;System These files look simple. I think they can be removed and replaced with DESKTOP_ENTRIES.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5176694.8gLySxXtyI>