Date: Wed, 20 Aug 2003 12:42:15 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 36517 for review Message-ID: <200308201942.h7KJgF1k086975@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=36517 Change 36517 by rwatson@rwatson_tislabs on 2003/08/20 12:41:52 IP fragment reassembly queues now potentially return an allocation failure since they are allocated while holding network mutexes and in interrupt context. As such, we need to use the waitcheck version of the network label allocation code in SEBSD. Otherwise, we use a function that calls MALLOC with M_WAITOK, generating a witness warning, and returns void, which likely causes IPQ allocation to fail in the MAC Framework. This prevented fragment reassembly from working with the SEBSD module loaded, breaking NFS (and no doubt other good stuff). Affected files ... .. //depot/projects/trustedbsd/sebsd/sys/security/sebsd/sebsd.c#14 edit Differences ... ==== //depot/projects/trustedbsd/sebsd/sys/security/sebsd/sebsd.c#14 (text+ko) ==== @@ -1929,7 +1929,7 @@ .mpo_init_devfsdirent_label = sebsd_init_vnode_label, .mpo_init_file_label = sebsd_init_file_label, .mpo_init_ifnet_label = sebsd_init_network_label, - .mpo_init_ipq_label = sebsd_init_network_label, + .mpo_init_ipq_label = sebsd_init_network_label_waitcheck, .mpo_init_mbuf_label = sebsd_init_network_label_waitcheck, .mpo_init_mount_label = sebsd_init_mount_label, .mpo_init_mount_fs_label = sebsd_init_mount_fs_label,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200308201942.h7KJgF1k086975>