Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Dec 2005 16:12:03 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 88882 for review
Message-ID:  <200512291612.jBTGC3Um056394@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=88882

Change 88882 by jhb@jhb_slimer on 2005/12/29 16:11:02

	WITNESS_SAVE/RESTORE doesn't work yet for spin locks.

Affected files ...

.. //depot/projects/smpng/sys/kern/kern_synch.c#94 edit

Differences ...

==== //depot/projects/smpng/sys/kern/kern_synch.c#94 (text+ko) ====

@@ -251,7 +251,9 @@
 	struct thread *td;
 	struct proc *p;
 	int rval;
+#if 0
 	WITNESS_SAVE_DECL(mtx);
+#endif
 
 	td = curthread;
 	p = td->td_proc;
@@ -277,7 +279,9 @@
 
 	DROP_GIANT();
 	mtx_assert(mtx, MA_OWNED | MA_NOTRECURSED);
+#if 0
 	WITNESS_SAVE(&mtx->mtx_object, mtx);
+#endif
 	mtx_unlock_spin(mtx);
 
 	/*
@@ -319,7 +323,9 @@
 #endif
 	PICKUP_GIANT();
 	mtx_lock_spin(mtx);
+#if 0
 	WITNESS_RESTORE(&mtx->mtx_object, mtx);
+#endif
 	return (rval);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200512291612.jBTGC3Um056394>