Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Oct 2004 20:36:52 +0000 (UTC)
From:      "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To:        Arjan de Vet <devet@devet.org>
Cc:        FreeBSD-gnats-submit@FreeBSD.org
Subject:    Re: kern/73038: if_sk.c seems to need IFF_NEEDSGIANT on 5.3-BETA/RC1
Message-ID:  <Pine.BSF.4.53.0410252033490.38216@e0-0.zab2.int.zabbadoz.net>
In-Reply-To: <20041023121049.A20631938D@adv.devet.org>
References:  <20041023121049.A20631938D@adv.devet.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 23 Oct 2004, Arjan de Vet wrote:

> >Fix:
>
> Index: if_sk.c
> ===================================================================
> RCS file: /home/freebsd/CVS/src/sys/pci/if_sk.c,v
> retrieving revision 1.83.2.2
> diff -u -r1.83.2.2 if_sk.c
> --- if_sk.c	25 Aug 2004 21:19:06 -0000	1.83.2.2
> +++ if_sk.c	23 Oct 2004 11:47:50 -0000
> @@ -1375,7 +1375,7 @@
>  	ifp->if_softc = sc_if;
>  	if_initname(ifp, device_get_name(dev), device_get_unit(dev));
>  	ifp->if_mtu = ETHERMTU;
> -	ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST;
> +	ifp->if_flags = IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST | IFF_NEEDSGIANT;
>  	ifp->if_ioctl = sk_ioctl;
>  	ifp->if_start = sk_start;
>  	ifp->if_watchdog = sk_watchdog;

does not help with for the tx path starvation problem here on
my amd64 with 5.3.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.53.0410252033490.38216>