Date: Wed, 27 Apr 2005 06:45:02 +0800 From: David Xu <davidxu@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_sig.c Message-ID: <426EC46E.8010701@freebsd.org> In-Reply-To: <200504261143.58152.jhb@FreeBSD.org> References: <200504190811.j3J8BSdx072259@repoman.freebsd.org> <200504261143.58152.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: >On Tuesday 19 April 2005 04:11 am, David Xu wrote: > > >>davidxu 2005-04-19 08:11:28 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_sig.c >> Log: >> Oops, forgot to update this file. >> Fix a race condition between kern_wait() and thread_stopped(). >> Problem is in kern_wait(), parent process steps through children list, >> once a child process is skipped, and later even if the child is stopped, >> parent process still sleeps in msleep(), the race happens if parent >> masked SIGCHLD. >> >> Submitted by : Peter Edwards peadar.edwards at gmail dot com >> MFC after : 4 days >> >> > >You're not setting P_STOPPED_SIG anymore, is that on purpose? > > > It is already tested in thread_stopped(), original stop() is called after the test, so there is no different.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?426EC46E.8010701>