Date: Thu, 28 Jan 2010 18:40:10 GMT From: Mark Linimon <linimon@lonesome.com> To: freebsd-fs@FreeBSD.org Subject: Re: kern/142924: Small cleanup for the inode struct in ext2fs (based on UFS) Message-ID: <201001281840.o0SIeAQX021094@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/142924; it has been noted by GNATS. From: Mark Linimon <linimon@lonesome.com> To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/142924: Small cleanup for the inode struct in ext2fs (based on UFS) Date: Thu, 28 Jan 2010 12:37:32 -0600 ----- Forwarded message from "Pedro F. Giffuni" <giffunip@tutopia.com> ----- From: "Pedro F. Giffuni" <giffunip@tutopia.com> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/142924: Small cleanup for the inode struct in ext2fs (based on UFS) Include two more simple patches from ufs_lookup.c: CVS 1.54: When compacting directories, ufs_direnter() always trusted DIRSIZ() to supply the number of bytes to be bcopy()'d to move an entry. If d_ino == 0 however, DIRSIZ() is not guaranteed to return a sensible length, so ufs_direnter could end up corrupting a directory during compaction. CVS 1.45: Extend the sanity checks in ufs_lookup to ensure that each directory entry fits within its DIRBLKSIZ block. _______ These were meant to fix issues found with dirhash on UFS but ext2fs still works here with those changes so I think it's good to have them, JIC we end up bringing over dirhash to ext2fs. ----- End forwarded message -----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001281840.o0SIeAQX021094>