Date: Mon, 28 Jun 2004 08:04:17 +0200 From: Kirill Ponomarew <krion@voodoo.oberon.net> To: Pav Lucistnik <pav@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/math/gnuplot Makefile Message-ID: <20040628060417.GM71637@voodoo.oberon.net> In-Reply-To: <1088380914.969.10.camel@hood.oook.cz> References: <200406271812.i5RICLjj014328@repoman.freebsd.org> <20040627235229.GA36136@misty.eyesbeyond.com> <1088380914.969.10.camel@hood.oook.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
--w2xx78T4DcG3O+DJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jun 28, 2004 at 02:01:54AM +0200, Pav Lucistnik wrote: =20 > In the unattended build, when no OPTIONS dialog is displayed, you don't > have any WITH* and WITHOUT* variables set. Your port should behave as if > default values were selected. >=20 > OPTIONS=3D OPTION "foo" on >=20 > Default is to have OPTION on. When no WITH/WITHOUT* variables are > generated, your test >=20 > .if defined(WITH_OPTION) >=20 > will fail. That's now the default you wanted. If you check instead >=20 > .if !defined(WITHOUT_OPTION) >=20 > it will work correctly in case OPTIONS were not processed. This nicely > demonstrates in unattended build on packages on Bento, for example. >=20 > > Also, why wasn't the PR assigned to the maintainer (me :)? >=20 > Ask krion :) Yeah, I should dress up my pointyhat for that ;) -Kirill --w2xx78T4DcG3O+DJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA37ThQC1G6a60JuURAt4qAKCAkOJY9+hfMFnDecu3azIo9llztwCgm9fh dyF+0SjN9iEbthnrOxamkJU= =5diq -----END PGP SIGNATURE----- --w2xx78T4DcG3O+DJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040628060417.GM71637>