Date: Wed, 10 Mar 2004 18:00:43 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 48556 for review Message-ID: <43076.1078938043@critter.freebsd.dk> In-Reply-To: Your message of "Wed, 10 Mar 2004 08:15:37 PST." <20040310161537.GA36028@dhcp01.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040310161537.GA36028@dhcp01.pn.xcllnt.net>, Marcel Moolenaar writ es: >On Wed, Mar 10, 2004 at 09:17:22AM +0100, Poul-Henning Kamp wrote: >> In message <200403100801.i2A810eC071863@repoman.freebsd.org>, Marcel Moolenaar >> > Note that most #ifdef DDB instances have to be replaced >> > with #ifdef DEBUG, because DDB is specific to a single >> > back-end, not to having debugging support in general. A >> > new option, GDB, has been added to add support for gdb. >> > This has to be worked-out still. >> >> #ifdef DEBUG is a singulary bad choice since much code have private >> use of that macro. > >The point of using a define is to be able to get rid of the debugger >calls in production systems. It doesn't matter if DEBUG has private >meaning as long as it relates to having debugging code. Other than >that, anything else is fine too, as long as it's not DDB. Well, having an option people cannot enable without crippling a lot of other code is no good either. I'll really suggest you use #ifdef KDB or something more specific than DEBUG. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43076.1078938043>