Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jul 2014 09:37:01 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        Garrett Cooper <yaneurabeya@gmail.com>
Cc:        "freebsd-fs@freebsd.org" <freebsd-fs@freebsd.org>, "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>
Subject:   Re: [REGRESSION] Root zpool mounting broken between 06/30/2013 and 07/21/2013 when PS/2 support compiled into the kernel
Message-ID:  <95A4D9A9-9D69-4258-A1EC-CBC6DC2F49FF@FreeBSD.org>
In-Reply-To: <3BFFF901-F5C0-4079-834E-F3199A188EF8@gmail.com>
References:  <78424E5D-4EB2-4462-A190-D0AC97136790@gmail.com> <201307221208.22060.jhb@freebsd.org> <EBEA5B58-A94B-4639-AFBA-181D4EE1D402@gmail.com> <3BFFF901-F5C0-4079-834E-F3199A188EF8@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jul 28, 2014, at 9:07 AM, Garrett Cooper <yaneurabeya@gmail.com> =
wrote:

> On Jul 22, 2013, at 10:58 AM, Garrett Cooper <yaneurabeya@gmail.com> =
wrote:
>=20
>> On Jul 22, 2013, at 9:08 AM, John Baldwin <jhb@freebsd.org> wrote:
>>=20
>>> On Monday, July 22, 2013 10:30:32 am Garrett Cooper wrote:
>>>> I have a KERNCONF that previously had PS/2 support compiled into =
the kernel. If I comment out the following lines like so:
>>>>=20
>>>> # atkbdc0 controls both the keyboard and the PS/2 mouse
>>>> #device         atkbdc          # AT keyboard controller
>>>> #device         atkbd           # AT keyboard
>>>>=20
>>>> then I'm able to mount root again (it was failing with ENOXDEV).
>>>>=20
>>>> The working kernel was as follows:
>>>>=20
>>>> $ strings /boot/kernel.WORKING/kernel | grep -B 2 -A 2 BAYONETTA
>>>> @(#)FreeBSD 9.1-STABLE #7 r+0304216: Sun Jun 30 15:22:55 PDT 2013
>>>> FreeBSD 9.1-STABLE #7 r+0304216: Sun Jun 30 15:22:55 PDT 2013
>>>>  =
gcooper@bayonetta.local:/usr/obj/scratch/git/github/yaneurabeya-freebsd-st=
able-9/sys/BAYONETTA
>>>> gcc version 4.2.1 20070831 patched [FreeBSD]
>>>> FreeBSD
>>>> 9.1-STABLE
>>>> BAYONETTA
>>>> $ cd /usr/src; git log 0304216
>>>> commit 03042167f73c213732b44218a24d8e1bbea00f8c
>>>> Merge: 2edcad2 974abfb
>>>> Author: Garrett Cooper <yanegomi@gmail.com>
>>>> Date:   Mon Jun 24 19:00:45 2013 -0700
>>>>=20
>>>>  Merge remote-tracking branch 'upstream/stable/9' into stable/9
>>>>=20
>>>> The working kernel [with atkbdc] was as follows:
>>>>=20
>>>> FreeBSD bayonetta.local 9.2-BETA1 FreeBSD 9.2-BETA1 #12 r+c178034: =
Sun Jul 21 20:19:38 PDT 2013    =20
>>> =
root@bayonetta.local:/usr/obj/scratch/git/github/yaneurabeya-freebsd-stabl=
e-9/sys/BAYONETTA  amd64
>>>> $ git log c178034
>>>> commit c17803445f4ffb97e1a46a1be5f7ea04692793f0
>>>> Author: avg <avg@FreeBSD.org>
>>>> Date:   Tue Jul 9 08:30:31 2013 +0000
>>>>=20
>>>>  zfsboottest.sh: remove checks for things that are not strictly =
required
>>>>=20
>>>>  MFC after:  10 days
>>>>=20
>>>> (Yes, I had to backport some things because they are busted on =
stable/9 due to other incomplete/missing MFCs).
>>>>=20
>>>> I can test out patches, but I don't have time to bisect the actual =
commit that caused the failure. That being said my intuition says it's =
this
>>> commit should be looked at first:
>>>>=20
>>>> commit 28f961058b0667841d7e9d8639bfd02ed8689faa
>>>> Author: jhb <jhb@FreeBSD.org>
>>>> Date:   Wed Jul 17 14:04:18 2013 +0000
>>>>=20
>>>>  MFC 252576:
>>>>  Don't perform the acpi_DeviceIsPresent() check for PCI-PCI =
bridges.  If
>>>>  we are probing a PCI-PCI bridge it is because we found one by =
enumerating
>>>>  the devices on a PCI bus, so the bridge is definitely present.  A =
few
>>>>  BIOSes report incorrect status (_STA) for some bridges that =
claimed they
>>>>  were not present when in fact they were.
>>>>=20
>>>>  While here, move this check earlier for Host-PCI bridges so attach =
fails
>>>>  before doing any work that needs to be torn down.
>>>>=20
>>>>  PR:         kern/91594
>>>>  Approved by:        re (marius)
>>>=20
>>> I strongly doubt that this is related.  It would be most helpful if =
you could
>>> obtain a dmesg from the new kernel however (perhaps via a serial =
console) to
>>> rule it out.  All you would need to see is if the new kernel sees =
more "pcib"
>>> devices than the old one to see if this change even has an effect on =
your
>>> system.
>>=20
>> Unfortunately the USB keyboard is broken as well at the mount root =
prompt and the workstation doesn't have a uart on it that I can play =
with (it's my home box), so I'm dead in the water when it panics at the =
mount root prompt right now.
>>=20
>> I guess I can revert this and a handful of other amd64/ata_cam/zfs =
commits to see if this goes away, but I won't be getting to that before =
next Sunday probably as this is my file server and DNS server now.
>=20
> 	I ran into the issue going from vanilla 9.2-RELEASE-p10 to =
9.3-RELEASE as well :(. I=92ve filed this bug to track the issue: =
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D192183 . I=92ll see =
if GENERIC can boot my system sometime this week (the KERNCONF has been =
working for several releases, but it could be an issue with that that=92s =
being overlooked by accident).
> Thanks!

There is basically zero chance that the commit in question can cause =
this.  Also, you would need to get verbose dmesg's of old and new =
kernels as a first step in narrowing it down.

--=20
John Baldwin









Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95A4D9A9-9D69-4258-A1EC-CBC6DC2F49FF>