Date: Mon, 13 Jan 2020 11:45:25 -0700 From: Ian Lepore <ian@freebsd.org> To: Toomas Soome <tsoome@me.com> Cc: Toomas Soome <tsoome@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356693 - in head/stand: efi/libefi i386/libi386 libofw uboot/lib Message-ID: <15236c9adbb7ec8c90375e283f7d1d5d5eafe6be.camel@freebsd.org> In-Reply-To: <4437F251-43CC-4DED-B449-00A9516C75E2@me.com> References: <202001131822.00DIMtrW016338@repo.freebsd.org> <5a3e388ed5c91a6d1f88ecc91c08dc103d0369d1.camel@freebsd.org> <4437F251-43CC-4DED-B449-00A9516C75E2@me.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2020-01-13 at 20:43 +0200, Toomas Soome wrote: > > On 13. Jan 2020, at 20:31, Ian Lepore <ian@freebsd.org> wrote: > > > > On Mon, 2020-01-13 at 18:22 +0000, Toomas Soome wrote: > > > Author: tsoome > > > Date: Mon Jan 13 18:22:54 2020 > > > New Revision: 356693 > > > URL: https://svnweb.freebsd.org/changeset/base/356693 > > > > > > Log: > > > loader: allocate properly aligned buffer for network packet > > > > > > Use memalign(4, size) to ensure we have properly aligned buffer. > > > > > > MFC after: 2 weeks > > > > > > Modified: > > > head/stand/efi/libefi/efinet.c > > > head/stand/i386/libi386/pxe.c > > > head/stand/libofw/ofw_net.c > > > head/stand/uboot/lib/net.c > > > > > > > The malloc implementation in libstand already g'tees minimum > > alignment > > of 16 bytes on most arches, 64 bytes on arches that use u-boot (see > > libsa/zalloc_defs.h). So how does this change anything? > > > > Hi! > > Well, given the amount of knobs etc, it does not hurt to be explicit, > does it? > > rgds, > toomas I think it does hurt, because now it misleads you into thinking it's 4- byte aligned when it's actually 16 or 64. (That's what made me reply at all, my first gut reaction to reading the commit message was "but 4 is not at all the right alignment on many platforms"). -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15236c9adbb7ec8c90375e283f7d1d5d5eafe6be.camel>