Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 Sep 2019 01:58:56 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r352465 - head/share/mk
Message-ID:  <201909180158.x8I1wuZu011258@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Wed Sep 18 01:58:56 2019
New Revision: 352465
URL: https://svnweb.freebsd.org/changeset/base/352465

Log:
  googletest: default-disable on all of MIPS for now
  
  Parts of the fusefs tests trigger a bug in current versions of llvm: IR
  representation of some routine for the MIPS targets is a function with a
  large number of arguments. This then leads the compiler on an hour+ long
  goose chase, which is OK if you build the current tree but less-so if you're
  trying external toolchain or doing a universe build involving mips when it
  eventually gets switched over to LLVM.
  
  Better, accurate details can be found in LLVM PR43263.

Modified:
  head/share/mk/src.opts.mk

Modified: head/share/mk/src.opts.mk
==============================================================================
--- head/share/mk/src.opts.mk	Wed Sep 18 01:33:17 2019	(r352464)
+++ head/share/mk/src.opts.mk	Wed Sep 18 01:58:56 2019	(r352465)
@@ -108,7 +108,6 @@ __DEFAULT_YES_OPTIONS = \
     GDB \
     GNU_DIFF \
     GNU_GREP \
-    GOOGLETEST \
     GPIO \
     HAST \
     HTML \
@@ -258,6 +257,15 @@ __T=${MACHINE_ARCH}
 __TT=${TARGET}
 .else
 __TT=${MACHINE}
+.endif
+
+# Default GOOGLETEST to off for MIPS while LLVM PR 43263 is active.  Part
+# of the fusefs tests trigger excessively long compile times.  It does
+# eventually succeed, but this shouldn't be forced on those building by default.
+.if ${__TT} == "mips"
+__DEFAULT_NO_OPTIONS+=	GOOGLETEST
+.else
+__DEFAULT_YES_OPTIONS+=	GOOGLETEST
 .endif
 
 # All supported backends for LLVM_TARGET_XXX



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201909180158.x8I1wuZu011258>