Date: Thu, 6 Apr 2000 05:30:02 -0700 (PDT) From: Sheldon Hearn <sheldonh@uunet.co.za> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/17824: [PATCH] /usr/bin/column has arithmetic overflows Message-ID: <200004061230.FAA65129@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/17824; it has been noted by GNATS.
From: Sheldon Hearn <sheldonh@uunet.co.za>
To: jdg@debian.org
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: bin/17824: [PATCH] /usr/bin/column has arithmetic overflows
Date: Thu, 06 Apr 2000 14:25:53 +0200
On Thu, 06 Apr 2000 02:06:54 MST, jdg@debian.org wrote:
> maxlength = (maxlength + TAB) & ~(TAB - 1);
> numcols = termwidth / maxlength;
> + if (!numcols) {
I don't get it. You still don't seem to be protecting against
divide-by-zero. Shouldn't you be testing the value of the dividend
before dividing?
Ciao,
Sheldon.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004061230.FAA65129>