Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Sep 2020 20:27:57 +0200
From:      Gunther Nikl <gnikl@justmail.de>
To:        Edward Tomasz Napierala <trasz@FreeBSD.org>
Cc:        svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r547170 - in head/lang/cbmbasic: . files
Message-ID:  <20200904202757.00003e4d@justmail.de>
In-Reply-To: <202008311222.07VCMXHw097278@repo.freebsd.org>
References:  <202008311222.07VCMXHw097278@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hello,

Edward Tomasz Napierala <trasz@FreeBSD.org> wrote:
> Author: trasz
> Date: Mon Aug 31 12:22:32 2020
> New Revision: 547170
> URL: https://svnweb.freebsd.org/changeset/ports/547170
> 
> Log:
>   Fix build ("ld: error: duplicate symbol: RAM").
> 
> Added:
>   head/lang/cbmbasic/files/
>   head/lang/cbmbasic/files/patch-Makefile   (contents, props changed)
> Modified:
>   head/lang/cbmbasic/Makefile
> 
> Modified: head/lang/cbmbasic/Makefile
> ==============================================================================
> --- head/lang/cbmbasic/Makefile	Mon Aug 31 11:59:09
> 2020	(r547169) +++ head/lang/cbmbasic/Makefile	Mon Aug
> 31 12:22:32 2020	(r547170) @@ -15,6 +15,8 @@
> USE_GITHUB=	yes GH_ACCOUNT=	mist64
>  GH_TAGNAME=	89093eba090d6e1c2d2b6e1cb1616dba0ce9c7f6
>  
> +CFLAGS+=	-fcommon
> +
>  PLIST_FILES=	bin/cbmbasic
>  
>  do-install:
> 
> Added: head/lang/cbmbasic/files/patch-Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is
> newly added) +++ head/lang/cbmbasic/files/patch-Makefile	Mon
> Aug 31 12:22:32 2020	(r547170) @@ -0,0 +1,14 @@
> +--- Makefile.orig	2014-12-06 23:57:18 UTC
> ++++ Makefile
> +@@ -1,10 +1,9 @@
> + OBJS=cbmbasic.o runtime.o plugin.o console.o
> +-CFLAGS=-Wall -O3
> + 
> + all: cbmbasic
> + 
> + cbmbasic: $(OBJS)
> +-	$(CC) -o cbmbasic $(OBJS)
> ++	$(CC) $(CFLAGS) -o cbmbasic $(OBJS)

Can you explain this change? Why are CFLAGS used when linking?

Regards,
Gunther



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200904202757.00003e4d>