Date: Mon, 01 Dec 2014 16:34:52 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Alfred Perlstein <bright@mu.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Alfred Perlstein <alfred@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys Message-ID: <547C8A9C.4080603@selasky.org> In-Reply-To: <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/01/14 16:29, Alfred Perlstein wrote: > > >> On Dec 1, 2014, at 7:26 AM, Hans Petter Selasky <hps@selasky.org> wrote: >> >>> On 12/01/14 16:19, Alfred Perlstein wrote: >>> It makes little sense to have a rw sysctl that only takes effect "some times". This violates POLA at the expense of making code appear cleaner. Expectation is that writable sysctls take >> >> Hi, >> >> I think you are missing a new feature in 11-current, that if you add "CTLFLAG_TUN" to even dynamic sysctls, they get initialized from the enviroment, if any. That way you can just skip the TUNABLE_INT_FETCH() stuff! >> > > Ok I can probably switch to that. > > Any objection if I mfc this feature to -stable if it does what I need? > Hi, No objections from me at least, but it might require some work from your side, because there was a lot of cleanup about removing duplicate definitions, like static SYSCTLS which have already CTLFLAG_TUN and a TUNABLE fetch statement, which makes the variable init twice. Just look at the revision history for "kern/kern_sysctl.c" in 11-current. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?547C8A9C.4080603>