Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Jan 2002 02:00:03 -0800 (PST)
From:      John Hay <jhay@icomtek.csir.co.za>
To:        freebsd-bugs@FreeBSD.org
Subject:   Re: bin/25627: Cannot append hash after .elif in Makefile
Message-ID:  <200201301000.g0UA03d76113@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/25627; it has been noted by GNATS.

From: John Hay <jhay@icomtek.csir.co.za>
To: sheldonh@starjuice.net (Sheldon Hearn)
Cc: freebsd-bugs@FreeBSD.ORG
Subject: Re: bin/25627: Cannot append hash after .elif in Makefile
Date: Wed, 30 Jan 2002 11:32:42 +0200 (SAT)

 >  For the audit trail:
 >  
 >  This one is _not_ awaiting MFC.  The patch was backed out in the following
 >  commit to parse.c:
 >  
 >  --------
 >  revision 1.28
 >  date: 2001/03/15 10:22:50;  author: will;  state: Exp;  lines: +10 -16
 >  Revert previous change -- apparently it's not quite right.  It broke
 >  src/sys/modules/if_ef and possibly other things.  I tested the build
 >  with
 >  a make based on rev. 1.26, and it worked fine.  Since I'm not
 >  particularly
 >  inclined to figure out what's going on with this, it's probably prudent
 >  just to back it out for now.
 >  
 >  Found by:	jkh
 >  Suggested by:	jhay
 >  --------
 >  
 >  Jordan, John?  Does either one of you have any more information that's
 >  likely to get this PR out of suspended state?  The audit trail doesn't
 >  include any objections to the patch.
 
 The only reason my name got dragged into this pr is because I complained
 that the patch caused make world/release to fail. As such I don't have
 anything against what the patch try to achieve as long as it does not
 break things.
 
 John
 -- 
 John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201301000.g0UA03d76113>