Date: Sun, 26 May 2019 07:05:20 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, gallatin@freebsd.org Subject: Re: svn commit: r348286 - in head/sys/dev: ctau cxgbe Message-ID: <2BE2FA91-38D0-4730-8A6A-BAF5037EB24E@gmail.com> In-Reply-To: <201905261241.x4QCf3ng086605@repo.freebsd.org> References: <201905261241.x4QCf3ng086605@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On May 26, 2019, at 05:41, Alexey Dokuchaev <danfe@freebsd.org> wrote: >=20 > Author: danfe (ports committer) > Date: Sun May 26 12:41:03 2019 > New Revision: 348286 > URL: https://svnweb.freebsd.org/changeset/base/348286 >=20 > Log: > Fix two errors reported by PVS Studio: V646 Consider inspecting the > application's logic. It's possible that 'else' keyword is missing. >=20 > Reviewed by: gallatin, np, pfg > Approved by: pfg > Differential Revision: https://reviews.freebsd.org/D20396 >=20 > Modified: > head/sys/dev/ctau/ctddk.c > head/sys/dev/cxgbe/t4_main.c >=20 > Modified: head/sys/dev/ctau/ctddk.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/dev/ctau/ctddk.c Sun May 26 03:52:35 2019 (r348285) > +++ head/sys/dev/ctau/ctddk.c Sun May 26 12:41:03 2019 (r348286) > @@ -237,7 +237,7 @@ int ct_set_clk (ct_chan_t *c, int clk) > if (c->mode =3D=3D M_E1) { > ct_setup_e1 (c->board); > return 0; > - } if (c->mode =3D=3D M_G703) { > + } else if (c->mode =3D=3D M_G703) { > ct_setup_g703 (c->board); > return 0; > } else This seems like a good candidate for a switch-case logical block. Cheers, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2BE2FA91-38D0-4730-8A6A-BAF5037EB24E>