Date: Sat, 27 Feb 2010 22:52:28 +0100 From: Patrick Lamaiziere <patfbsd@davenulle.org> To: "freebsd-drivers@freebsd.org" <freebsd-drivers@freebsd.org> Cc: "Kennedy, Brendan" <brendan.kennedy@intel.com>, "Philip@freebsd.org" <Philip@freebsd.org> Subject: Re: [PATCH] patch to OpenCrypto framework Message-ID: <20100227225228.470e9b7b@davenulle.org> In-Reply-To: <CFBC532374C38D45810FA00BC2D2C2041FB949@irsmsx502.ger.corp.intel.com> References: <CFBC532374C38D45810FA00BC2D2C2041FB949@irsmsx502.ger.corp.intel.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Le Wed, 24 Feb 2010 16:50:35 +0000, "Kennedy, Brendan" <brendan.kennedy@intel.com> a écrit : > Hi Philip, All, Hello, > This OpenCrypto patch does a number of updates: > > 1) It updates Cryptodev to allocate contiguous memory blocks – a > requirement for some hardware drivers I don't see the benefit for this one -changing malloc(9) to contigmalloc(9)- it introduces a small (but useless) overhead to existing drivers (I tried with glxsb : we lose around 5%). IMO, if this is required for some drivers, this is not the good place to do this. A crypto driver can receive data from somewhere else than cryptodev: ipsec, geli, kerberos (at least) Best regards.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100227225228.470e9b7b>