Date: Sat, 8 Jan 2011 19:18:09 +0100 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-stable@freebsd.org, Nick Hibma <nick@van-laarhoven.org> Cc: freebsd-multimedia@freebsd.org, kwm@freebsd.org, Kris Moore <kris@pcbsd.org> Subject: Re: Webcamd testers wanted on FreeBSD 8.2 Message-ID: <201101081918.09664.hselasky@c2i.net> In-Reply-To: <201101081841.10690.hselasky@c2i.net> References: <201101081841.10690.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-00=_hpKKNWNCVpMh/2S
Content-Type: Text/Plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
On Saturday 08 January 2011 18:41:10 Hans Petter Selasky wrote:
> Hi,
>
> Can someone running FreeBSD 8.2-RC1 with more than one or external USB
> webcam or DVB-XXX devices verify the following:
>
> 1) Install /usr/ports/multimedia/webcamd
>
> 2) Reboot
>
> 3) Check that character devices are created for your device(s) under /dev
>
> /dev/videoX for webcams
>
> /dev/dvb/adapterX for DVB devices
>
> 3) HAL should show your device.
>
> lshal | grep -i video
> lshal | grep -i dvb
>
> 4) Hot replug the USB plug of your USB webcam/DVB device, perform checks
> 1,2 and 3. If same result everything is OK.
>
Hi,
After that the devd notify string was changed last year, hald stopped
registering attached USB devices because the match string was too narrow. Can
someone with HAL knowledge please review the attached patch for
/usr/ports/sysutils/hal .
My patch uses strstr() instead of strncmp(), but really a full parse with
respect to " characters is required, because cdev=ugen, could appear inside
some strings.
When it works, lshal will show USB devices plugged after boot.
--HPS
--Boundary-00=_hpKKNWNCVpMh/2S
Content-Type: text/x-patch;
charset="ISO-8859-1";
name="hal.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="hal.patch"
diff -ur hal.orig/files/patch-hald_freebsd_hf-usb2.c hal/files/patch-hald_freebsd_hf-usb2.c
--- hal.orig/files/patch-hald_freebsd_hf-usb2.c 2011-01-08 19:01:54.000000000 +0100
+++ hal/files/patch-hald_freebsd_hf-usb2.c 2011-01-08 19:05:14.000000000 +0100
@@ -133,8 +133,8 @@
+ (strcmp(type, "CREATE") && strcmp(type, "DESTROY")))
+ return FALSE;
+
-+ if (! strncmp(data, "cdev=ugen", strlen("cdev=ugen")) ||
-+ ! strncmp(data, "cdev=usb", strlen("cdev=usb")))
++ if ((strstr(data, "cdev=ugen") != NULL) ||
++ (strstr(data, "cdev=usb") != NULL))
+ return TRUE;
+
+ return FALSE;
--Boundary-00=_hpKKNWNCVpMh/2S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101081918.09664.hselasky>