Date: Fri, 9 Jul 2010 08:27:09 -0400 From: John Baldwin <jhb@freebsd.org> To: Doug Barton <dougb@freebsd.org> Cc: ports@freebsd.org Subject: Re: Review request for new port: sysutils/etcupdate Message-ID: <201007090827.09471.jhb@freebsd.org> In-Reply-To: <alpine.BSF.2.00.1007081505550.48494@yncgbc.qbhto.arg> References: <201007081750.00871.jhb@freebsd.org> <alpine.BSF.2.00.1007081505550.48494@yncgbc.qbhto.arg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, July 08, 2010 6:12:39 pm Doug Barton wrote: > On Thu, 8 Jul 2010, John Baldwin wrote: > > > This is a port for yet-another-/etc-merging tool that I wrote recently. It > > passes portlint -N with one bogus warning because /etc is in the comment. > > I didn't try installing/deinstalling but you seem to have the right > stuff in the Makefile for that. Overall it looks good, just a couple > comments: > 1. I don't think textproc is right for CATEGORIES, although sysutils is > of course. > 2. I don't think the do-fetch target is necessary, but if it is needed > when you test it that's fine. > 3. You have a pkg-descr~ file in the shar that should be deleted before > you commit it. > > Assuming it passes all the tests in the porter's handbook for install, > deinstall, package, etc. I'd say go ahead. :) Ok. Should I fix 1) and 2) for the sysutils/etcmerge port as well? (I used etcmerge as a template.) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201007090827.09471.jhb>