Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Feb 2002 18:58:04 +0000 (GMT)
From:      Mike Silbersack <silby@silby.com>
To:        Jonathan Hanna <jhanna@shaw.ca>
Cc:        vs3volod@yahoo.com, <hackers@FreeBSD.ORG>, Karl Dietz <Karl.Dietz@triplan.com>
Subject:   RE: ping: sendto: No buffer space available
Message-ID:  <20020210185451.Y29546-100000@patrocles.silby.com>
In-Reply-To: <200202092056.g19Ku8j00368@207-194-143-195.dsl.axion.net>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sat, 9 Feb 2002, Jonathan Hanna wrote:

>
> This looks like the bug in the "ep" driver. When the interrupt routine
> gets both TX and RX interrupts it acknowledges both but only services
> the read. Karl Dietz, <Karl.Dietz@TRIPLAN.com> is working on an overhaul
> but my quick fix is to take out the "continue" after the "epread()" in
> ep_intr(). The buffer talked about is actually the ep queue being full.
>
> --- if_ep.c     Fri Feb  1 19:51:43 2002
> +++ if_ep.c.fix Sat Feb  9 12:49:31 2002
> @@ -571,7 +571,6 @@
>
>         if (status & (S_RX_COMPLETE | S_RX_EARLY)) {
>             epread(sc);
> -           continue;
>         }
>         if (status & S_TX_AVAIL) {
>             /* we need ACK */

If this fix is solid, should it be applied now to the ep driver?  Should
we wait until the driver merge is complete?  I don't own any cards that
use the ep chipset, but if that change fixes bugs for multiple ep users I
wouldn't be opposed to committing it for you.

Mike "Silby" Silbersack


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020210185451.Y29546-100000>