Date: Tue, 27 Jun 2017 18:06:16 +0100 From: Andrew Turner <andrew@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320388 - head/sys/arm64/include Message-ID: <0842F153-8120-4D7C-B6B3-E2499CD05286@freebsd.org> In-Reply-To: <61D9C30C-BB98-484E-B817-6FE369A77453@gmail.com> References: <201706262232.v5QMWrBs048496@repo.freebsd.org> <61D9C30C-BB98-484E-B817-6FE369A77453@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 27 Jun 2017, at 18:04, Ngie Cooper (yaneurabeya) = <yaneurabeya@gmail.com> wrote: >=20 >=20 >> On Jun 26, 2017, at 15:32, Andrew Turner <andrew@FreeBSD.org> wrote: >>=20 >> Author: andrew >> Date: Mon Jun 26 22:32:52 2017 >> New Revision: 320388 >> URL: https://svnweb.freebsd.org/changeset/base/320388 >>=20 >> Log: >> In _bswap16 and _bswap32 cast constant values to the appropriate = type. This is >> similar to what is done in the x86 code. >>=20 >> Sponsored by: DARPA, AFRL >=20 > Hi Andrew, > This change broke htons use in libsdp on arm64. =46rom = https://ci.freebsd.org/job/FreeBSD-head-aarch64-build/2932/console : >=20 > 16:08:38 --- all_subdir_lib/libsdp --- > 16:08:38 /usr/src/lib/libsdp/search.c:160:31: error: invalid operands = to binary expression ('int' and 'uint8_t *' (aka 'unsigned char *')) > 16:08:38 xpdu.pdu.len =3D htons(req_cs - ss->req); >=20 > 16:08:38 ~~~~~~~~~~~~~^~~~~~~~~~ >=20 > It might be a good idea to revert the change, fix the fallout, = then recommit the change. > Thanks, > -Ngie I already fixed it in r320411. Andrew=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0842F153-8120-4D7C-B6B3-E2499CD05286>