Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Mar 2003 14:26:22 -0500 (EST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Nate Lawson <nate@root.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c
Message-ID:  <XFMail.20030331142622.jhb@FreeBSD.org>
In-Reply-To: <Pine.BSF.4.21.0303310933500.7433-100000@root.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 31-Mar-2003 Nate Lawson wrote:
> On Mon, 31 Mar 2003, Nate Lawson wrote:
>>   Modified files:
>>     sys/pci              if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c 
>>                          if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c 
>>                          if_wb.c if_xl.c 
>>   Log:
>>   Clean up locking and resource management for pci/if_*
> 
> This is a rather large patch so if you begin to experience problems
> attaching or detaching (say on module load/unload) a previously-working
> card, please let me know.

Already found a bogon in tl(4) when it conflicted with some local
changes.  Might want to double check that you don't call detach()
for very early failures when you have no resources to teardown or
release but just do a direct return in the other drivers.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030331142622.jhb>