Date: Tue, 1 Jun 2010 01:49:48 +0900 From: Norikatsu Shigemura <nork@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases Makefile ports/databases/flare Makefile distinfo pkg-descr pkg-plist ports/databases/flare/files flared.sh.in flarei.sh.in patch-etc-flared.conf patch-etc-flarei.conf patch-flared-flared.cc patch-flared-ini_option.cc ... Message-ID: <20100601014948.771f2b98.nork@FreeBSD.org> In-Reply-To: <4C02D5E9.4000400@FreeBSD.org> References: <201005300441.o4U4foHS067210@repoman.freebsd.org> <4C02D5E9.4000400@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi dougb. On Sun, 30 May 2010 14:17:29 -0700 Doug Barton <dougb@FreeBSD.org> wrote: > There are numerous problems with the rc.d scripts for this port. The > single biggest problem is that no new scripts should be added with the > .sh suffix, as it's never installed that way anymore. The attached patch > fixes the other problems, but I haven't changed the file names in order > to make the changes obvious. Thanks for your review & suggestion. I forgot ports handbook style (*1). (*1) http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html I missed some copy&paste from ports/net/cvsync/files/cvsyncd.in, e.g. I wont use *_conffile, it's toooo error! I committed, thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100601014948.771f2b98.nork>