Date: Sat, 23 Jan 2010 22:25:17 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 173596 for review Message-ID: <201001232225.o0NMPHaE031052@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/chv.cgi?CH=173596 Change 173596 by rwatson@rwatson_cinnamon on 2010/01/23 22:25:15 Don't allow VOP_SETATTR() on fdescfs -- we could build up a capability rights mask for the operations it represents, but it actually isn't very coherent conceptually. For example, you can chmod /dev/fd/X if that fd refers to a file, but if you stat() you don't see the file's mode. Affected files ... .. //depot/projects/trustedbsd/capabilities/src/sys/fs/fdescfs/fdesc_vnops.c#8 edit Differences ... ==== //depot/projects/trustedbsd/capabilities/src/sys/fs/fdescfs/fdesc_vnops.c#8 (text+ko) ==== @@ -391,6 +391,8 @@ struct ucred *a_cred; } */ *ap; { + +#if 0 struct vnode *vp = ap->a_vp; struct vattr *vap = ap->a_vap; @@ -430,6 +432,9 @@ vp->v_type = vap->va_type; return (0); +#else + return (EOPNOTSUPP); +#endif } static int
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001232225.o0NMPHaE031052>