Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 09 Apr 2018 11:40:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 227387] Mk/bsd.port.mk: Try to fix make clean for non-flavored dependency
Message-ID:  <bug-227387-7788-4SwxCNMmYz@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-227387-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-227387-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227387

--- Comment #2 from Fukang Chen <loader@FreeBSD.org> ---
Sure. Thanks koobs@.

FLAVOR=3Dpy27 is passed to the dependency ftp/curl through env:
https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view=
=3Dmarkup#l3814
3813  limited-clean-depends-${_f}:
3814          @cd ${.CURDIR} && ${SETENV} FLAVOR=3D${_f} ${MAKE}
limited-clean-depends
3815  .endif

then ${WRKDIR} turns to be /usr/ports/ftp/curl/work-py27 when it reaches he=
re:
https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view=
=3Dmarkup#l1663
1663    .if empty(FLAVOR)
1664    _WRKDIR=3D        work
1665    .else
1666    _WRKDIR=3D        work-${FLAVOR}
1667    .endif
1668=20=20=20=20
1669    WRKDIR?=3D                ${WRKDIRPREFIX}${.CURDIR}/${_WRKDIR}

The first "=3D=3D=3D>  Cleaning for curl-7.59.0" is executed by the
pre-clean-noflavor: target:
https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view=
=3Dmarkup#l3789
3789    pre-clean-noflavor:
3790            @cd ${.CURDIR} && ${SETENV} ${MAKE} pre-clean
3791    .endif

The Second "=3D=3D=3D>  Cleaning for curl-7.59.0" is excuted by the pre-cle=
an-py27:
target:
https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view=
=3Dmarkup#l3818
3818    pre-clean-${_f}:
3819            @cd ${.CURDIR} && ${SETENV} FLAVOR=3D${_f} ${MAKE} pre-clean
3820    .endif



Current behaviour:
# cd /usr/ports/ftp/py-pycurl
# make -C /usr/ports/ftp/curl BATCH=3D1 extract
=3D=3D=3D>  License MIT accepted by the user
=3D=3D=3D>   curl-7.59.0 depends on file: /usr/local/sbin/pkg - found
=3D=3D=3D> Fetching all distfiles required by curl-7.59.0 for building
=3D=3D=3D>  Extracting for curl-7.59.0
=3D> SHA256 Checksum OK for curl-7.59.0.tar.xz.
# make clean
=3D=3D=3D>  Cleaning for curl-7.59.0
=3D=3D=3D>  Cleaning for curl-7.59.0
=3D=3D=3D>  Cleaning for py27-pycurl-7.43.0.1
=3D=3D=3D>  Cleaning for curl-7.59.0
=3D=3D=3D>  Cleaning for curl-7.59.0
=3D=3D=3D>  Cleaning for py36-pycurl-7.43.0.1
# test -d /usr/ports/ftp/curl/work ; echo $?
0

Expected behaviour (with patch):
# cd /usr/ports/ftp/py-pycurl
# make -C /usr/ports/ftp/curl BATCH=3D1 extract
=3D=3D=3D>  License MIT accepted by the user
=3D=3D=3D>   curl-7.59.0 depends on file: /usr/local/sbin/pkg - found
=3D=3D=3D> Fetching all distfiles required by curl-7.59.0 for building
=3D=3D=3D>  Extracting for curl-7.59.0
=3D> SHA256 Checksum OK for curl-7.59.0.tar.xz.
# make clean
=3D=3D=3D>  Cleaning for curl-7.59.0
=3D=3D=3D>  Cleaning for py27-pycurl-7.43.0.1
=3D=3D=3D>  Cleaning for py36-pycurl-7.43.0.1
# test -d /usr/ports/ftp/curl/work ; echo $?
1

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227387-7788-4SwxCNMmYz>