Date: Tue, 22 Jun 2010 16:21:36 +0200 From: Ivan Voras <ivoras@freebsd.org> To: Garrett Cooper <gcooper@freebsd.org> Cc: Andrew Pantyukhin <infofarmer@freebsd.org>, Perforce Change Reviews <perforce@freebsd.org>, Julien LAFFAYE <jlaffaye@freebsd.org> Subject: Re: PERFORCE change 180026 for review Message-ID: <AANLkTimbD6gwV6X-9iPma5bKsRQ4nvcBTD8E95StVSoo@mail.gmail.com> In-Reply-To: <AANLkTils97pZPnrVCG3qUY_B5iCcnTGPgxxeqpWRvWOO@mail.gmail.com> References: <201006210045.o5L0jgZ3009138@repoman.freebsd.org> <AANLkTilVcTOnaHwihB4IZVi7KZldCrD2Ion28XCSuOgg@mail.gmail.com> <AANLkTimpzTbsP_2ztEZd6S5Cxhyga54PWYwAhCFYVtuP@mail.gmail.com> <AANLkTils97pZPnrVCG3qUY_B5iCcnTGPgxxeqpWRvWOO@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 June 2010 03:25, Garrett Cooper <gcooper@freebsd.org> wrote: > On Sun, Jun 20, 2010 at 6:15 PM, Ivan Voras <ivoras@freebsd.org> wrote: >> On 21 June 2010 02:58, Julien LAFFAYE <jlaffaye@freebsd.org> wrote: >>> Why don't you use read_plist(Package *pkg, int fd) from libpkg instead? >> >> Should I, in the light of >> YES_I_KNOW_THE_API_IS_RUBBISH_AND_IS_DOOMED_TO_CHANGE ? I thought the >> entire lib is to be rightfully scrapped and implemented as something >> decent. > > =C2=A0 =C2=A0Yes, it will be eventually, but there's no real harm in > implementing this bit with read_plist for the time being though. If > and when dforsyth's work gets straightened out, a lot of this crud > will get scrapped and/or properly rewritten. Just to confirm this: for example, if I need to get the MD5 hash of a file from this structure, is the accepted practice to scan through the entire list searching for the file node and then scan the rest of the list searching for the first comment node that begins with "MD5:"?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimbD6gwV6X-9iPma5bKsRQ4nvcBTD8E95StVSoo>