Date: Sat, 16 Jul 2016 06:55:44 +0800 From: "Euan Thoms" <euan@potensol.com> To: "Don Lewis" <truckman@FreeBSD.org> Cc: koobs@FreeBSD.org, martin@waschbuesch.de, freebsd-ports@freebsd.org, w.schwarzenfeld@utanet.at Subject: =?utf-8?q?Re=3A?==?utf-8?q?_devel=2Fsope=3A?= make =?utf-8?q?=28stage-qa=29?= now fails with =?utf-8?q?DEVELOPER=3Dyes?= complaining about iconv dependency Message-ID: <7c85-57896a00-11-6b8b4580@130330797> In-Reply-To: <201607151610.u6FGAE5N037400@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, July 16, 2016 00:10 SGT, Don Lewis <truckman@FreeBSD.org> = wrote: > On 15 Jul, Euan Thoms wrote: > > > > On Friday, July 15, 2016 15:26 SGT, Kubilay Kocak <koobs@FreeBSD.or= g> > > wrote: > > > >> On 15/07/2016 5:17 PM, Martin Waschb=C3=BCsch wrote: > >> > > >> >> Am 14.07.2016 um 23:29 schrieb Euan Thoms <euan@potensol.com>: = > >> >> > >> >> > >> >> On Friday, July 15, 2016 01:11 SGT, Walter Schwarzenfeld > >> >> <w.schwarzenfeld@utanet.at> wrote: > >> >> > >> >>> I think this statements should be only warnings. Cause not all= > >> >>> of these statements are right and each maintianer should decid= e > >> >>> which "USES" or "LIB=5FDEPENDS" are necessairely and which not= . > >> >> > >> >> Well, I don't know enough to comment about whether it should be= > >> >> classed as a warning or an error. But there's definetely a bug = in > >> >> the ports Mk system, since adding USES+=3Diconv does not remove= the > >> >> error. I don't think I even need iconv as a dependency, it shou= ld > >> >> be included lower down in the dependency tree. > >> > > >> > I am not sure about this. At the very least, sope-core does use = > >> > iconv in its NGExtensions (e.g. NSString+Encoding.m). Can we rea= lly > >> > assume some lower dependency package already pulls iconv in? > >> > >> If something in a port links to libiconv (or anything else), then = > >> the dependency should be registered in that port > >> > > > > OK, thanks guys. I will add libiconv as a LIB=5FDEPENDS. But I stil= l > > think there may be a bug. The make error tells me to use USES+=3Dic= onv > > and it doesn't work, I still get the same error about libiconv not = > > being specified as a dependancy. > > It looks like USES=3Diconv doesn't add the dependency on newer FreeBS= D > versions that have basic iconv support in the base system. If you se= t > USES=3Diconv:wchar=5Ft or USES=3Diconv:translit, then it will uncondi= tionally > add the dependency. > > If you don't use the WCHAR=5FT or //TRANSLIT extensions, it may not b= e > necessary to link with -liconv, but it is possible that the port does= > this automatically if it finds that libiconv is installed by another = > dependency. > Aha, in that case perhaps ignore my last email. This starts to make mor= e sense now. although the stage-qa error message is misleading. Is this case, would I not be better adding a LIB=5FDEPENDS instead of U= SES=3Diconv.wchar=5Ft or USES=3Diconv:translit? I don't even know where= to find out which one I need. A bit off tpic, but personally I prefer to just use the LIB=5FDEPENDS f= or a straight dependency. Keeping track of which macros to use can be m= ore difficult than the time they save. I've only been porting for about= a year, yet the ports system seems to be going through a lot of change= s in this time. All good changes I'm sure. As a user I do find installi= ng and upgrading easier than I did when I strated using ports about 5 y= ears ago. I'm just about to start working on the port again now. -- Regards, Euan Thoms
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c85-57896a00-11-6b8b4580>