Date: Tue, 17 Jan 2006 14:55:40 -0800 From: Frank Mayhar <frank@exit.com> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: cvs-src@freebsd.org, Alfred Perlstein <alfred@freebsd.org>, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vnops.c src/sys/fs/msdosfs msdosfs_denode.c src/sys/fs/ntfs ntfs_vnops.c src/sys/fs/nwfs nwfs_node.c src/sys/fs/smbfs smbfs_node.c src/sys/fs/udf udf_vnops.c src/sys/isofs/cd9660 cd9660_node.c src/sys/nfsclient ... Message-ID: <1137538540.2350.8.camel@realtime.exit.com> In-Reply-To: <20060117225028.2f014c1e@Magellan.Leidinger.net> References: <200601171729.k0HHT3Ng026618@repoman.freebsd.org> <20060117225028.2f014c1e@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2006-01-17 at 22:50 +0100, Alexander Leidinger wrote: > On Tue, 17 Jan 2006 17:29:03 +0000 (UTC) > Alfred Perlstein <alfred@FreeBSD.org> wrote: > > to be identical, as if they were just clones of one original routine. > "Clones" as in identical and could be refactored into one function? As "refactored" is just a pretentious term for "rewritten," yes, pretty much. All of the xxx_reclaim() functions that I fixed were essentially identical. > Do you think this panic can be triggered by e.g. letting rhytmbox run > over a lot of music files on 2 msdosfs partitions to update the music > library? Yes, if it's dirtying pages on msdosfs (by, say, changing access times) and msdosfs has a putpages routine, _and_ that routine is called as a result of the destroy_object call. Otherwise no. -- Frank Mayhar frank@exit.com http://www.exit.com/ Exit Consulting http://www.gpsclock.com/ http://www.exit.com/blog/frank/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1137538540.2350.8.camel>