Date: Mon, 27 Sep 2021 14:25:59 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Guido Falsi <madpilot@freebsd.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 895bc805a975 - main - www/webkit2-gtk3: update to 2.34.0 Message-ID: <YVHUd611hX%2Bom5qs@FreeBSD.org> In-Reply-To: <7efc5dc6-483e-e2e9-b84d-eb37979527f8@FreeBSD.org> References: <202109270840.18R8e9bN044971@gitrepo.freebsd.org> <b6d28582-4a05-473d-58d1-3257a990173c@FreeBSD.org> <20210927100250.3f6injyvuw6lbufp@aniel.nours.eu> <8af11968-8b08-3e5c-e0de-56f1f63f57b0@FreeBSD.org> <a4a19c28-d1ec-e899-af69-0dbf14a9cd81@FreeBSD.org> <63723cf0-1dea-f4c6-6d48-d91cbb4e7ebb@FreeBSD.org> <YVHLaiB7Ol41KRW0@FreeBSD.org> <7efc5dc6-483e-e2e9-b84d-eb37979527f8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 27, 2021 at 04:10:14PM +0200, Guido Falsi wrote: > On 27/09/21 15:47, Alexey Dokuchaev wrote: > > On Mon, Sep 27, 2021 at 03:38:09PM +0200, Guido Falsi wrote: > >> ... > >> I noticed I have the GSTREAMER option disabled in that poudriere jail. > >> > >> Enabling GSTREAMER again makes it compile. > >> > >> So while this narrows things down the option should be removed or fixed. > > > > Please don't remove this very useful option, at most it could be marked as > > BROKEN unilt it's fixed. I'll look into it once I have some spare time. > > I suspect I was not perfectly clear. The option works when enabled, but > when disabled brakes the port. This was quite clear. I suspect it was me who wasn't clear: when I said "marked as BROKEN" I meant the option, not the port, but even what's not really called for. > So by "removing the option" i meant just that, remove the option and > make the functionality mandatory. And this is what I'm against. I always disable GStreamer in all the ports I can, so this option is important, hence please don't remove it and give those who's motivated enough some time to look into fixing it. It's not a big deal and most users won't notice as it's enabled by default, but removing and then reintroducing it would cause needless repochurn. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVHUd611hX%2Bom5qs>